Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 512993002: Remove dead code in Autofill. (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove dead code in Autofill. This line can't be reached because it's already guarded by a check to IsAutofillable(). Also, change a method signature to take a const ref. BUG=none Committed: https://crrev.com/8ac2ad2945de828afa49435357d5c4f1f59f4387 Cr-Commit-Position: refs/heads/master@{#292724}

Patch Set 1 #

Patch Set 2 : also switch non-const point to const ref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M components/autofill/core/browser/autofill_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Evan Stade
estade@chromium.org changed reviewers: + isherman@chromium.org
6 years, 3 months ago (2014-08-28 01:19:02 UTC) #1
Evan Stade
ping
6 years, 3 months ago (2014-08-29 17:23:48 UTC) #2
Evan Stade
On 2014/08/29 17:23:48, Evan Stade wrote: > ping hmm, I guess the "changed reviewers" message ...
6 years, 3 months ago (2014-08-29 17:49:39 UTC) #3
Ilya Sherman
LGTM, thanks.
6 years, 3 months ago (2014-08-29 17:52:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/512993002/20001
6 years, 3 months ago (2014-08-29 18:06:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ba67085532088fc44dcb5a9125dd5a4138be7f4e
6 years, 3 months ago (2014-08-30 00:02:47 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:11:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ac2ad2945de828afa49435357d5c4f1f59f4387
Cr-Commit-Position: refs/heads/master@{#292724}

Powered by Google App Engine
This is Rietveld 408576698