Issue 512983005: Cleanup some touch adjustment FIXMEs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 512983005: Cleanup some touch adjustment FIXMEs (Closed)

Created:
6 years, 3 months ago by Rick Byers

Modified:
6 years, 3 months ago

Reviewers:
Zeeshan Qureshi

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-reviews-events_chromium.org, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Cleanup some touch adjustment FIXMEs This is a few little cleanups which I left behind as FIXMEs in previous changes that were designed to be merge-worthy. I don't believe any of these changes should have an observable effect in real usage. They are a pre-requisite, however, for additional fixes I intend to make. BUG=398914 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181672

Patch Set 1 #

Patch Set 2 : Merge with trunk #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -12 lines)			Patch
M	Source/core/page/EventHandler.cpp	View	1	2 chunks	+13 lines, -7 lines	0 comments	Download
M	Source/core/rendering/HitTestResult.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/HitTestResult.cpp	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Rick Byers

rbyers@chromium.org changed reviewers: + zeeshanq@chromium.org

6 years, 3 months ago (2014-08-28 19:16:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/512983005/20001

6 years, 3 months ago (2014-09-09 19:22:49 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-09 20:31:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 181672

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages