Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 512983004: Revert of Replace NPObject usage in ppapi with gin (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Revert of Replace NPObject usage in ppapi with gin (patchset #26 of https://codereview.chromium.org/459553003/) Reason for revert: Crash in telemetry tests http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/6615 Original issue's description: > Replace NPObject usage in ppapi with gin > > This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side. > > There are 4 major parts to this CL: > 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc). > 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects. > 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects. > 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8. > > > BUG=351636 > > Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3 TBR=jochen@chromium.org,dmichael@chromium.org,kolczyk@opera.com NOTREECHECKS=true NOTRY=true BUG=351636 Committed: https://crrev.com/93b2c74d78b7b9d9bcb8d45e7987e93a349772e7 Cr-Commit-Position: refs/heads/master@{#292322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1350 lines, -991 lines) Patch
M content/content_renderer.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/pepper/host_var_tracker.h View 3 chunks +41 lines, -29 lines 0 comments Download
M content/renderer/pepper/host_var_tracker.cc View 4 chunks +75 lines, -79 lines 0 comments Download
M content/renderer/pepper/host_var_tracker_unittest.cc View 2 chunks +52 lines, -66 lines 0 comments Download
M content/renderer/pepper/message_channel.h View 4 chunks +38 lines, -53 lines 0 comments Download
M content/renderer/pepper/message_channel.cc View 7 chunks +349 lines, -181 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 7 chunks +11 lines, -10 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 12 chunks +52 lines, -57 lines 0 comments Download
M content/renderer/pepper/pepper_try_catch.h View 4 chunks +6 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_try_catch.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 3 chunks +17 lines, -15 lines 0 comments Download
M content/renderer/pepper/plugin_object.h View 3 chunks +45 lines, -38 lines 0 comments Download
M content/renderer/pepper/plugin_object.cc View 3 chunks +324 lines, -189 lines 0 comments Download
M content/renderer/pepper/ppb_var_deprecated_impl.cc View 2 chunks +301 lines, -228 lines 0 comments Download
M content/renderer/pepper/v8_var_converter.h View 2 chunks +2 lines, -8 lines 0 comments Download
M content/renderer/pepper/v8_var_converter.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M content/renderer/pepper/v8object_var.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ppapi/shared_impl/scoped_pp_var.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/shared_impl/scoped_pp_var.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
raymes
Created Revert of Replace NPObject usage in ppapi with gin
6 years, 3 months ago (2014-08-28 04:49:44 UTC) #1
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 3 months ago (2014-08-28 04:50:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/512983004/1
6 years, 3 months ago (2014-08-28 04:51:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 43f5bc98dd4c5fefb73bc4f563bae54c4a479ebd
6 years, 3 months ago (2014-08-28 04:52:18 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:57:34 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93b2c74d78b7b9d9bcb8d45e7987e93a349772e7
Cr-Commit-Position: refs/heads/master@{#292322}

Powered by Google App Engine
This is Rietveld 408576698