Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 512983003: Remove .apk from dangerous file extension list (Closed)

Created:
6 years, 3 months ago by felt
Modified:
6 years, 3 months ago
Reviewers:
asanka, palmer
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove .apk from dangerous file extension list BUG=404472 Committed: https://crrev.com/9e8ca6bef7de6728ea12d83ec15b17bf2d79473b Cr-Commit-Position: refs/heads/master@{#292473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/download/download_extensions.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
felt
felt@chromium.org changed reviewers: + asanka@chromium.org, palmer@chromium.org
6 years, 3 months ago (2014-08-28 03:28:23 UTC) #1
felt
PTAL. I wasn't sure whether to remove .dex also; does Android also show a confirmation ...
6 years, 3 months ago (2014-08-28 03:28:50 UTC) #2
asanka
LGTM
6 years, 3 months ago (2014-08-28 05:39:34 UTC) #3
palmer
LGTM. Let's leave it as-is for now; to download a .dex file would be very ...
6 years, 3 months ago (2014-08-28 20:51:46 UTC) #4
felt
The CQ bit was checked by felt@chromium.org
6 years, 3 months ago (2014-08-28 20:53:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/512983003/1
6 years, 3 months ago (2014-08-28 20:54:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as fcf3779861b87e6bafe3f937b74f397ce92d7c23
6 years, 3 months ago (2014-08-28 21:50:11 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e8ca6bef7de6728ea12d83ec15b17bf2d79473b
Cr-Commit-Position: refs/heads/master@{#292473}

Powered by Google App Engine
This is Rietveld 408576698