Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 512983002: Revert of Fix HidService lifetime issues. (Closed)

Created:
6 years, 3 months ago by eroman
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Fix HidService lifetime issues. (patchset #3 of https://codereview.chromium.org/464753002/) Reason for revert: Caused build failure: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/69507/steps/compile/logs/stdio Original issue's description: > Fix HidService lifetime issues. > > This reverts HidService to a singleton instance, adding two gross > and presently hard-to-avoid properties: > > 1. Its instance getter takes a UI message loop proxy > 2. Its lifetime is bound by the message loop of its origin thread > > The purpose of this is to preserve the necessary threading discipline > required by both the chrome.hid API implementation and the > permission_broker DBus client while ensuring that the HidService is > created and destroyed on the same thread. > > BUG=401234 > > Committed: https://chromium.googlesource.com/chromium/src/+/13aca592b24cdeb9b558716db71c48961e48066f TBR=reillyg@chromium.org,rpaquay@chromium.org,rockot@chromium.org NOTREECHECKS=true NOTRY=true BUG=401234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -68 lines) Patch
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M device/hid/hid_connection_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/hid/hid_service.h View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service.cc View 2 chunks +6 lines, -45 lines 0 comments Download
M device/hid/hid_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/extensions_api_client.h View 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.h View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A extensions/shell/browser/api/shell_extensions_api_client.h View 1 chunk +28 lines, -0 lines 0 comments Download
A extensions/shell/browser/api/shell_extensions_api_client.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eroman
Created Revert of Fix HidService lifetime issues.
6 years, 3 months ago (2014-08-28 00:15:20 UTC) #1
awong
6 years, 3 months ago (2014-08-28 00:21:09 UTC) #2
The CQ bit was unchecked by ajwong@chromium.org

Powered by Google App Engine
This is Rietveld 408576698