Clears focus on gesture event.

Clears focus on gesture event.

This will cancel the virtual keyboard.

BUG=404110, 403813
R=oshima@chromium.org
TEST=manually && athena_unittests

Committed: https://crrev.com/2bcb4b7e71028b5a22c2435ebe0bd2213ceccd71
Cr-Commit-Position: refs/heads/master@{#292483}

[oshima, 2014-08-28 19:33:12]

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:159: if (from_state != HomeCard::VISIBLE_CENTERED
||
We probably don't want to clear focus when a user is using keyboard.
Can you add TODO to find out ideal behavior and update?

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_un...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:36: }
altenatively, you can use view ID to get the view that you're interested.

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:238: aura::Window* home_card =
HomeCard::Get()->GetHomeCardWindowForTest();
don't you need to cast to impl?

[Jun Mukai, 2014-08-28 21:26:26]

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:159: if (from_state != HomeCard::VISIBLE_CENTERED
||
On 2014/08/28 19:33:12, oshima wrote:
> We probably don't want to clear focus when a user is using keyboard.
> Can you add TODO to find out ideal behavior and update?
> 

Done.

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_un...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:36: }
On 2014/08/28 19:33:12, oshima wrote:
> altenatively, you can use view ID to get the view that you're interested.

Done.

https://codereview.chromium.org/512963002/diff/20001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:238: aura::Window* home_card =
HomeCard::Get()->GetHomeCardWindowForTest();
On 2014/08/28 19:33:12, oshima wrote:
> don't you need to cast to impl?

Fixed. Relies on old code.

[oshima, 2014-08-28 21:28:47]

lgtm

[Jun Mukai, 2014-08-28 21:32:05]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-28 21:32:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/512963002/40001

[commit-bot: I haz the power, 2014-08-28 22:45:31]

Committed patchset #3 (id:40001) as cd4520f62fe664fb8e835bfee6b8193499c64270

[commit-bot: I haz the power, 2014-09-10 03:02:58]

Patchset 3 (id:??) landed as
https://crrev.com/2bcb4b7e71028b5a22c2435ebe0bd2213ceccd71
Cr-Commit-Position: refs/heads/master@{#292483}