components/autofill/core/browser/personal_data_manager_mac.mm - Issue 512933004: mac: Don't show "Access Address Book" prompt if Autofill is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager_mac.mm

Issue 512933004: mac: Don't show "Access Address Book" prompt if Autofill is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to estade's style suggestion. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_manager_unittest.cc ('K') | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager_mac.mm

diff --git a/components/autofill/core/browser/personal_data_manager_mac.mm b/components/autofill/core/browser/personal_data_manager_mac.mm

index 52d8e5f09809471badad9d0d36eb288f42255297..4080d3c66c9f66eeea42e8b493eb4f9398b89893 100644

--- a/components/autofill/core/browser/personal_data_manager_mac.mm

+++ b/components/autofill/core/browser/personal_data_manager_mac.mm

@@ -363,6 +363,9 @@ bool PersonalDataManager::AccessAddressBook() {

bool PersonalDataManager::ShouldShowAccessAddressBookSuggestion(

AutofillType type) {

+ if (!enabled_pref_->GetValue())

+ return false;

if (HasPromptedForAccessToAddressBook(pref_service_))

return false;