components/autofill/core/browser/autofill_manager.cc - Issue 512933004: mac: Don't show "Access Address Book" prompt if Autofill is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 512933004: mac: Don't show "Access Address Book" prompt if Autofill is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix logic in autofill manager. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 68d2a361e98cdff996d11e5d7def52bbd4fa7053..a9404f1db3685b019db8a084ccd4bdf8a4572892 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -292,6 +292,9 @@ bool AutofillManager::ShouldShowAccessAddressBookSuggestion(

if (!GetCachedFormAndField(form, field, &form_structure, &autofill_field))

return false;

+ if (!field.should_autocomplete)

Evan Stade 2014/08/28 17:18:58 nit: combine this with the check on L288

erikchen 2014/08/28 17:28:46 Done.

+ return false;

return personal_data_->ShouldShowAccessAddressBookSuggestion(

autofill_field->Type());

}

« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »