components/autofill/core/browser/autofill_manager.cc - Issue 512933004: mac: Don't show "Access Address Book" prompt if Autofill is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 512933004: mac: Don't show "Access Address Book" prompt if Autofill is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Require forms be autofillable. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager.h ('k') | components/autofill/core/browser/personal_data_manager_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 68d2a361e98cdff996d11e5d7def52bbd4fa7053..42eb3a9b2e32e3c2a142e1376e65f7c49e81b92a 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -292,6 +292,9 @@ bool AutofillManager::ShouldShowAccessAddressBookSuggestion(

if (!GetCachedFormAndField(form, field, &form_structure, &autofill_field))

return false;

+ if (!form_structure->IsAutofillable())

Evan Stade 2014/08/28 00:33:16 why are we even getting to this point if the form

erikchen 2014/08/28 00:39:37 I don't know. See the first exchange between isher

+ return false;

Ilya Sherman 2014/08/28 00:34:19 Could you add test coverage for this change as wel

erikchen 2014/08/28 17:01:17 Done.

return personal_data_->ShouldShowAccessAddressBookSuggestion(

autofill_field->Type());

}