components/autofill/core/browser/autofill_manager.cc - Issue 512933004: mac: Don't show "Access Address Book" prompt if Autofill is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 512933004: mac: Don't show "Access Address Book" prompt if Autofill is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments from estade (remove mock function). Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 68d2a361e98cdff996d11e5d7def52bbd4fa7053..ea0167dc82a4dc0b1cdbad85d167ca22be8e935b 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -285,8 +285,9 @@ void AutofillManager::ShowAutofillSettings() {

bool AutofillManager::ShouldShowAccessAddressBookSuggestion(

const FormData& form,

const FormFieldData& field) {

- if (!personal_data_)

+ if (!personal_data_ || !field.should_autocomplete)

return false;

Ilya Sherman 2014/08/28 18:40:49 We still shouldn't be showing these suggestions fo

erikchen 2014/08/28 20:57:34 Added the check.

FormStructure* form_structure = NULL;

AutofillField* autofill_field = NULL;

if (!GetCachedFormAndField(form, field, &form_structure, &autofill_field))

« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »