mac: Don't show "Access Address Book" prompt if Autofill is disabled.

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/memory/ref_counted.h"
@@ skipping 115 matching lines @@
   void CreateTestCreditCardsYearAndMonth(const char* year, const char* month) {
     ClearCreditCards();
     CreditCard* credit_card = new CreditCard;
     test::SetCreditCardInfo(credit_card, "Miku Hatsune",
                             "4234567890654321", // Visa
                             month, year);
     credit_card->set_guid("00000000-0000-0000-0000-000000000007");
     credit_cards_.push_back(credit_card);
   }
 
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+  bool ShouldShowAccessAddressBookSuggestion(AutofillType type) { return true; }

[Evan Stade, 2014/08/28 17:31:55]

where is this used? is it supposed to be virtual/OVERRIDE?

[erikchen, 2014/08/28 17:37:52]

Yup. Good catch, the method it was overriding wasn't virtual. :(

[Evan Stade, 2014/08/28 17:42:32]

can you just remove it instead?

[erikchen, 2014/08/28 18:14:46]

Done.

+#endif  // defined(OS_MACOSX) && !defined(OS_IOS)
+
  private:
   void CreateTestAutofillProfiles(ScopedVector<AutofillProfile>* profiles) {
     AutofillProfile* profile = new AutofillProfile;
     test::SetProfileInfo(profile, "Elvis", "Aaron",
                          "Presley", "theking@gmail.com", "RCA",
                          "3734 Elvis Presley Blvd.", "Apt. 10",
                          "Memphis", "Tennessee", "38116", "US",
                          "12345678901");
     profile->set_guid("00000000-0000-0000-0000-000000000001");
     profiles->push_back(profile);
@@ skipping 2627 matching lines @@
   int id = PackGUIDs(empty, guid_pair);
 
   autofill_manager_->RemoveAutofillProfileOrCreditCard(id);
 
   // TODO(csharp): Currently variants should not be deleted, but once they are
   // update these expectations.
   // http://crbug.com/124211
   EXPECT_TRUE(autofill_manager_->GetProfileWithGUID(guid.c_str()));
 }
 
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+TEST_F(AutofillManagerTest, AccessAddressBookPrompt) {
+  FormData form;
+  test::CreateTestAddressFormData(&form);
+  std::vector<FormData> forms(1, form);
+  FormsSeen(forms);
+  FormFieldData& field = form.fields[0];
+
+  field.should_autocomplete = false;
+  EXPECT_FALSE(
+      autofill_manager_->ShouldShowAccessAddressBookSuggestion(form, field));
+
+  field.should_autocomplete = true;
+  EXPECT_TRUE(
+      autofill_manager_->ShouldShowAccessAddressBookSuggestion(form, field));
+}
+#endif  // defined(OS_MACOSX) && !defined(OS_IOS)
+
 namespace {
 
 class MockAutofillClient : public TestAutofillClient {
  public:
   MockAutofillClient() {}
 
   virtual ~MockAutofillClient() {}
 
   virtual void ShowRequestAutocompleteDialog(
       const FormData& form,
@@ skipping 23 matching lines @@
   test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);  // should call the delegate's OnQuery()
 
   EXPECT_TRUE(external_delegate_->on_query_seen());
 }
 
 }  // namespace autofill