Use PassiveObject were possible.

Use PassiveObject were possible.

Committed: https://code.google.com/p/dart/source/detail?r=39687

[siva, 2014-08-27 20:45:05]

asiva@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2014-08-28 19:31:54]

LGTMwC -ip

https://codereview.chromium.org/512933002/diff/1/runtime/vm/deopt_instruction...
File runtime/vm/deopt_instructions.cc (right):

https://codereview.chromium.org/512933002/diff/1/runtime/vm/deopt_instruction...
runtime/vm/deopt_instructions.cc:341: PassiveObject& obj =
PassiveObject::Handle();
Handle(isolate())

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:13340: return result.raw() == Object::bool_true().raw();
I don't think we need to wrap it in a handle to compare the raw values with a VM
predefined object.

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:18116: RawArray* Array::Grow(const Array& source,
Should we be requiring the isolate be passed into this as the first parameter?

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:18410: ASSERT(map.Release().raw() == data());
You could stick the ASSERT in a NoGCScope and then we do not need to
wrap/unwrap.

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:19089: void Stacktrace::Append(const Array& code_list,
Pass in isolate over here?

https://codereview.chromium.org/512933002/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/512933002/diff/1/runtime/vm/snapshot.cc#newco...
runtime/vm/snapshot.cc:194: PassiveObject& obj =
PassiveObject::Handle(ReadObjectImpl());
Handle(isolate_, ...)

[siva, 2014-08-29 00:17:02]

https://codereview.chromium.org/512933002/diff/1/runtime/vm/deopt_instruction...
File runtime/vm/deopt_instructions.cc (right):

https://codereview.chromium.org/512933002/diff/1/runtime/vm/deopt_instruction...
runtime/vm/deopt_instructions.cc:341: PassiveObject& obj =
PassiveObject::Handle();
On 2014/08/28 19:31:53, Ivan Posva wrote:
> Handle(isolate())

Done.

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:13340: return result.raw() == Object::bool_true().raw();
On 2014/08/28 19:31:53, Ivan Posva wrote:
> I don't think we need to wrap it in a handle to compare the raw values with a
VM
> predefined object.

Done.

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:18116: RawArray* Array::Grow(const Array& source,
I added a local variable isolate and used that in all the three
handle creation calls here.

On 2014/08/28 19:31:53, Ivan Posva wrote:
> Should we be requiring the isolate be passed into this as the first parameter?

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:18410: ASSERT(map.Release().raw() == data());
On 2014/08/28 19:31:53, Ivan Posva wrote:
> You could stick the ASSERT in a NoGCScope and then we do not need to
> wrap/unwrap.

Done.

https://codereview.chromium.org/512933002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:19089: void Stacktrace::Append(const Array& code_list,
I added a local variable isolate and used that in all the handle
creation in this function.

On 2014/08/28 19:31:53, Ivan Posva wrote:
> Pass in isolate over here?

https://codereview.chromium.org/512933002/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/512933002/diff/1/runtime/vm/snapshot.cc#newco...
runtime/vm/snapshot.cc:194: PassiveObject& obj =
PassiveObject::Handle(ReadObjectImpl());
On 2014/08/28 19:31:54, Ivan Posva wrote:
> Handle(isolate_, ...)

Done.

[siva, 2014-08-29 00:22:23]

Committed patchset #2 (id:20001) manually as r39687 (presubmit successful).