Issue 512753002: Disable some changes tests on ARM64. Also, fix the changes lowering to not use the more expensive T…

Issue 512753002: Disable some changes tests on ARM64. Also, fix the changes lowering to not use the more expensive T… (Closed)

Created:
6 years, 3 months ago by titzer

Modified:
6 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Disable some changes tests on ARM64. Also, fix the changes lowering to not use the more expensive TruncateFloat64ToInt32, but to use ChangeFloat64ToInt32/ChangeFloat64ToUint32, as it was before. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23460

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -42 lines)			Patch
M	src/compiler/change-lowering.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/change-lowering.cc	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	test/cctest/compiler/test-changes-lowering.cc	View	1	5 chunks	+66 lines, -33 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nit. https://codereview.chromium.org/512753002/diff/1/test/cctest/compiler/test-changes-lowering.cc File test/cctest/compiler/test-changes-lowering.cc (right): https://codereview.chromium.org/512753002/diff/1/test/cctest/compiler/test-changes-lowering.cc#newcode310 test/cctest/compiler/test-changes-lowering.cc:310: TEST(RunChangeInt32ToTagged_smi) { nit: s/_smi/Smi/ https://codereview.chromium.org/512753002/diff/1/test/cctest/compiler/test-changes-lowering.cc#newcode327 test/cctest/compiler/test-changes-lowering.cc:327: ...

6 years, 3 months ago (2014-08-27 13:29:22 UTC) #2

titzer

Committed patchset #2 manually as 23460 (presubmit successful).

6 years, 3 months ago (2014-08-27 13:49:38 UTC) #3

titzer

6 years, 3 months ago (2014-08-27 13:51:09 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/512753002/diff/1/test/cctest/compiler/test-ch...
File test/cctest/compiler/test-changes-lowering.cc (right):

https://codereview.chromium.org/512753002/diff/1/test/cctest/compiler/test-ch...
test/cctest/compiler/test-changes-lowering.cc:310:
TEST(RunChangeInt32ToTagged_smi) {
On 2014/08/27 13:29:22, Michael Starzinger wrote:
> nit: s/_smi/Smi/

Done.

https://codereview.chromium.org/512753002/diff/1/test/cctest/compiler/test-ch...
test/cctest/compiler/test-changes-lowering.cc:327:
TEST(RunChangeUint32ToTagged_smi) {
On 2014/08/27 13:29:22, Michael Starzinger wrote:
> nit: s/_smi/Smi/

Done.

Expand Messages | Collapse Messages