Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 512733004: Fixed the example JSON strings for Windows and Linux. (Closed)

Created:
6 years, 3 months ago by Joao da Silva
Modified:
6 years, 3 months ago
Reviewers:
pastarmovj
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Fixed the example JSON strings for Windows and Linux. The example policies weren't valid JSON because they used single quotes instead of double quotes. BUG=None R=pastarmovj@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M grit/format/policy_templates/writers/doc_writer.py View 3 chunks +4 lines, -3 lines 0 comments Download
M grit/format/policy_templates/writers/doc_writer_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Joao da Silva
joaodasilva@chromium.org changed reviewers: + pastarmovj@chromium.org
6 years, 3 months ago (2014-08-28 14:34:13 UTC) #1
Joao da Silva
PTAL, thanks!
6 years, 3 months ago (2014-08-28 14:34:13 UTC) #2
pastarmovj
lgtm
6 years, 3 months ago (2014-08-28 15:14:26 UTC) #3
Joao da Silva
6 years, 3 months ago (2014-08-28 15:22:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r174 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698