Source/core/dom/Node.cpp - Issue 51273002: Have ChildFrameDisconnector / ChildListMutationScope deal with references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.cpp

Issue 51273002: Have ChildFrameDisconnector / ChildListMutationScope deal with references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Node.cpp

diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp

index deb789d648f5c49cb255d46064bf1b09c6317e2b..89f80b54a0abb8e03fe2d50d433194f6fae29cd6 100644

--- a/Source/core/dom/Node.cpp

+++ b/Source/core/dom/Node.cpp

@@ -1564,7 +1564,7 @@ void Node::setTextContent(const String& text, ExceptionState& es)

case ENTITY_NODE:

case DOCUMENT_FRAGMENT_NODE: {

RefPtr<ContainerNode> container = toContainerNode(this);

- ChildListMutationScope mutation(this);

+ ChildListMutationScope mutation(*this);

container->removeChildren();

if (!text.isEmpty())

container->appendChild(document().createTextNode(text), es);

« no previous file with comments | « Source/core/dom/MutationObserverInterestGroup.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »