Issue 51273002: Have ChildFrameDisconnector / ChildListMutationScope deal with references

Issue 51273002: Have ChildFrameDisconnector / ChildListMutationScope deal with references (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
adamk

CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Have ChildFrameDisconnector / ChildListMutationScope deal with references Have ChildFrameDisconnector / ChildListMutationScope deal with references instead of pointers as these could never be null. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160877

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -91 lines)			Patch
M	Source/core/css/PropertySetCSSStyleDeclaration.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/CharacterData.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/ChildListMutationScope.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/dom/ChildListMutationScope.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/ContainerNode.cpp	View	13 chunks	+37 lines, -36 lines	0 comments	Download
M	Source/core/dom/ContainerNodeAlgorithms.h	View	3 chunks	+18 lines, -18 lines	0 comments	Download
M	Source/core/dom/ContainerNodeAlgorithms.cpp	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/MutationObserverInterestGroup.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/dom/MutationObserverInterestGroup.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Node.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/markup.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/51273002/1

7 years, 1 month ago (2013-10-29 20:24:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/51273002/1

7 years, 1 month ago (2013-10-29 20:40:35 UTC) #4

Message was sent while issue was closed.

Change committed as 160877

Expand Messages | Collapse Messages