Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 512703003: Revert of Remove unused PPB_View_Dev (Closed)

Created:
6 years, 3 months ago by dmichael (off chromium)
Modified:
6 years, 3 months ago
Reviewers:
raymes, binji
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, raymes+watch_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, Sam Clegg, ihf+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove unused PPB_View_Dev (patchset #3 of https://codereview.chromium.org/498123002/) Reason for revert: I should've checked sooner; this is apparently still used by Flash. (See go/UMA, histograms, Pepper.InterfaceUsed) Original issue's description: > Remove unused PPB_View_Dev > > TBR=binji@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/2210d5fb49cd4b75972f2e304b29637c050de4f1 TBR=binji@chromium.org,raymes@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/dfb32745ba203c79a72579de583f8c7ef676d216 Cr-Commit-Position: refs/heads/master@{#292152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -0 lines) Patch
M chrome/browser/component_updater/ppapi_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi/library.dsc View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/api/dev/ppb_view_dev.idl View 1 chunk +46 lines, -0 lines 0 comments Download
A ppapi/c/dev/ppb_view_dev.h View 1 chunk +65 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/view_dev.h View 1 chunk +44 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/view_dev.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 2 chunks +4 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +2 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_view_dev_thunk.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
Created Revert of Remove unused PPB_View_Dev
6 years, 3 months ago (2014-08-27 14:46:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/512703003/1
6 years, 3 months ago (2014-08-27 14:47:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as fc146ac482b8347b440e1d749626d3fbaf02ac95
6 years, 3 months ago (2014-08-27 14:47:49 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfb32745ba203c79a72579de583f8c7ef676d216
Cr-Commit-Position: refs/heads/master@{#292152}

Powered by Google App Engine
This is Rietveld 408576698