Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 512703002: Revert of Service Worker: Add tests for same-scope new script registration (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
Reviewers:
michaeln, falken, nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of Service Worker: Add tests for same-scope new script registration (patchset #6 of https://codereview.chromium.org/480943002/) Reason for revert: This is crashing on Mac. Original issue's description: > Service Worker: Add tests for same-scope, new script registration > > Tests for Chromium patch: > https://codereview.chromium.org/506043002/ > > BUG=398355 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180948 TBR=michaeln@chromium.org,nhiroki@chromium.org,falken@chromium.org NOTREECHECKS=true NOTRY=true BUG=398355 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -366 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html View 1 chunk +0 lines, -254 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/test-helpers.js View 1 chunk +8 lines, -18 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html View 6 chunks +25 lines, -94 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mlamouri (slow - plz ping)
Created Revert of Service Worker: Add tests for same-scope new script registration
6 years, 3 months ago (2014-08-27 10:38:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/512703002/1
6 years, 3 months ago (2014-08-27 10:39:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as 180956
6 years, 3 months ago (2014-08-27 10:39:51 UTC) #3
horo
6 years, 3 months ago (2014-09-11 12:16:16 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/547743003/ by horo@chromium.org.

The reason for reverting is: This crash will be fixed by
https://codereview.chromium.org/556003006..

Powered by Google App Engine
This is Rietveld 408576698