Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6740)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

Issue 512683003: Password bubble should close if user clicks on the web page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
index 1627e3be24d96dd72461c51996eccaec922d865b..1f9b887ad38bc47b28756491359598a32d0eed43 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
@@ -226,6 +226,9 @@ class ManagePasswordsBubbleView : public ManagePasswordsBubble,
virtual void OnMouseEntered(const ui::MouseEvent& event) OVERRIDE;
virtual void OnMouseExited(const ui::MouseEvent& event) OVERRIDE;
+ // Called from WebContentMouseHandler when user clicks the web view.
+ void OnWebContentClicked();
+
void set_initially_focused_view(views::View* view) {
DCHECK(!initially_focused_view_);
initially_focused_view_ = view;
@@ -248,6 +251,9 @@ class ManagePasswordsBubbleView : public ManagePasswordsBubble,
// Timer used to close the bubble after timeout.
base::OneShotTimer<ManagePasswordsBubbleView> timer_;
+ class WebContentMouseHandler;
+ scoped_ptr<WebContentMouseHandler> mouse_handler_;
+
DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleView);
};

Powered by Google App Engine
This is Rietveld 408576698