Password bubble should close if user clicks on the web page.

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
 
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 #include "chrome/browser/ui/views/passwords/manage_password_item_view.h"
 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/password_manager/core/common/password_manager_ui.h"
 #include "content/public/browser/notification_source.h"
+#include "content/public/browser/web_contents.h"
+#include "ui/aura/window.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/combobox_model.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/text_utils.h"
 #include "ui/views/controls/button/blue_button.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/controls/combobox/combobox.h"
 #include "ui/views/controls/styled_label.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/layout/grid_layout.h"
@@ skipping 475 matching lines @@
   parent_->Close();
 }
 
 void ManagePasswordsBubbleView::SaveConfirmationView::ButtonPressed(
     views::Button* sender, const ui::Event& event) {
   DCHECK_EQ(sender, ok_button_);
   parent_->model()->OnOKClicked();
   parent_->Close();
 }
 
+// ManagePasswordsBubbleView::WebContentMouseHandler --------------------------
+
+// The class listens WebContentsView for mouse clicks.

[vabr (Chromium), 2014/08/27 16:43:05]

nit: listens -> listens to

[vabr (Chromium), 2014/08/27 16:43:05]

nit: Could you extend the comment to say what the class does about the clicks?
For example:
The class listens to WebContentsView and notifies the bubble if the view was
clicked on.

[vasilii, 2014/08/27 17:24:24]

Done.

[vasilii, 2014/08/27 17:24:24]

Done.

+class ManagePasswordsBubbleView::WebContentMouseHandler
+    : public ui::EventHandler {
+ public:
+  explicit WebContentMouseHandler(ManagePasswordsBubbleView* bubble)
+      : bubble_(bubble) {
+    GetWebContentsWindow()->AddPreTargetHandler(this);
+  }
+
+  virtual ~WebContentMouseHandler() {
+    aura::Window* window = GetWebContentsWindow();
+    if (window)
+      window->RemovePreTargetHandler(this);
+  }
+
+  virtual void OnMouseEvent(ui::MouseEvent* event) OVERRIDE {
+    if (event->type() == ui::ET_MOUSE_PRESSED)
+      bubble_->OnWebContentClicked();
+  }
+
+ private:
+  aura::Window* GetWebContentsWindow() {
+    content::WebContents* web_contents = bubble_->model()->web_contents();
+    return web_contents ? web_contents->GetNativeView() : NULL;
+  }
+
+  ManagePasswordsBubbleView* bubble_;
+
+  DISALLOW_COPY_AND_ASSIGN(WebContentMouseHandler);
+};
+
 // ManagePasswordsBubbleView --------------------------------------------------
 
 // static
 ManagePasswordsBubbleView* ManagePasswordsBubbleView::manage_passwords_bubble_ =
     NULL;
 
 // static
 void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,
                                            DisplayReason reason) {
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
@@ skipping 61 matching lines @@
                          anchor_view ? views::BubbleBorder::TOP_RIGHT
                                      : views::BubbleBorder::NONE),
       anchor_view_(anchor_view),
       never_save_passwords_(false),
       initially_focused_view_(NULL) {
   // Compensate for built-in vertical padding in the anchor view's image.
   set_anchor_view_insets(gfx::Insets(5, 0, 5, 0));
   set_notify_enter_exit_on_child(true);
   if (anchor_view)
     anchor_view->SetActive(true);
+  mouse_handler_.reset(new WebContentMouseHandler(this));
 }
 
 ManagePasswordsBubbleView::~ManagePasswordsBubbleView() {
   if (anchor_view_)
     anchor_view_->SetActive(false);
 }
 
 void ManagePasswordsBubbleView::AdjustForFullscreen(
     const gfx::Rect& screen_bounds) {
   if (GetAnchorView())
@@ skipping 88 matching lines @@
 
 void ManagePasswordsBubbleView::StartTimerIfNecessary() {
   // Active bubble will stay visible until it loses focus.
   if (GetWidget()->IsActive())
     return;
   timer_.Start(FROM_HERE,
                base::TimeDelta::FromSeconds(kBubbleCloseDelay),
                this,
                &ManagePasswordsBubbleView::Close);
 }
+
+void ManagePasswordsBubbleView::OnWebContentClicked() {
+  Close();
+}