Issue 512683002: Fix tracking area initialization for the mac password bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 512683002: Fix tracking area initialization for the mac password bubble. (Closed)

Created:
6 years, 3 months ago by dconnelly

Modified:
6 years, 3 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix tracking area initialization for the mac password bubble. It turns out specifying a "when" option is required, or it throws an exception :( BUG= Committed: https://crrev.com/fbcfb84493065cd31fd50a4cde1d9580b93d8211 Cr-Commit-Position: refs/heads/master@{#292153}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dconnelly

dconnelly@chromium.org changed reviewers: + shess@chromium.org

6 years, 3 months ago (2014-08-27 09:24:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/512683002/1

6 years, 3 months ago (2014-08-27 14:11:19 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as cf5171fd8aa7fee1428f5069eeec3655ba653b9a

6 years, 3 months ago (2014-08-27 15:15:20 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:51:43 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fbcfb84493065cd31fd50a4cde1d9580b93d8211
Cr-Commit-Position: refs/heads/master@{#292153}

Expand Messages | Collapse Messages