Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 512673002: Revert "Track empty username and password in PasswordStore." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/login_database.cc
diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc
index e4efba909aa5b7a014665200b3426513b1c158ca..d9e6f09195ec454b97f5e5d02dbcf92aeced7fed 100644
--- a/components/password_manager/core/browser/login_database.cc
+++ b/components/password_manager/core/browser/login_database.cc
@@ -8,7 +8,6 @@
#include <limits>
#include "base/bind.h"
-#include "base/debug/dump_without_crashing.h"
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
@@ -118,12 +117,6 @@ void AddCallback(int err, sql::Statement* /*stmt*/) {
DLOG(WARNING) << "LoginDatabase::AddLogin updated an existing form";
}
-// http://crbug.com/404012. Let's see where the empty fields come from.
-void CheckForEmptyUsernameAndPassword(const PasswordForm& form) {
- if (form.username_value.empty() && form.password_value.empty())
- base::debug::DumpWithoutCrashing();
-}
-
} // namespace
LoginDatabase::LoginDatabase() {
@@ -359,7 +352,6 @@ void LoginDatabase::ReportMetrics(const std::string& sync_username) {
}
PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) {
- CheckForEmptyUsernameAndPassword(form);
PasswordStoreChangeList list;
std::string encrypted_password;
if (EncryptedString(form.password_value, &encrypted_password) !=
@@ -403,7 +395,6 @@ PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) {
}
PasswordStoreChangeList LoginDatabase::UpdateLogin(const PasswordForm& form) {
- CheckForEmptyUsernameAndPassword(form);
std::string encrypted_password;
if (EncryptedString(form.password_value, &encrypted_password) !=
ENCRYPTION_RESULT_SUCCESS)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698