Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 512673002: Revert "Track empty username and password in PasswordStore." (Closed)

Created:
6 years, 3 months ago by vasilii
Modified:
6 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Track empty username and password in PasswordStore." This reverts https://codereview.chromium.org/493123002. There were too many generated crashes. BUG=407767 Committed: https://crrev.com/7b9995c5960eab6cba301070fc26a8d95a30aa27 Cr-Commit-Position: refs/heads/master@{#292134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M components/password_manager/core/browser/login_database.cc View 4 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vasilii
vasilii@chromium.org changed reviewers: + vabr@chromium.org
6 years, 3 months ago (2014-08-27 09:17:35 UTC) #1
vasilii
Hi Vaclav, please review ASAP. We need to land it today.
6 years, 3 months ago (2014-08-27 09:19:53 UTC) #2
vabr (Chromium)
LGTM, I checked both that it is a revert of https://codereview.chromium.org/493123002, and that it makes ...
6 years, 3 months ago (2014-08-27 10:47:56 UTC) #3
vasilii
The CQ bit was checked by vasilii@chromium.org
6 years, 3 months ago (2014-08-27 10:48:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/512673002/1
6 years, 3 months ago (2014-08-27 10:49:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as c75ffec437147b59a4d42972d948c2a52a13f873
6 years, 3 months ago (2014-08-27 11:22:42 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b9995c5960eab6cba301070fc26a8d95a30aa27
Cr-Commit-Position: refs/heads/master@{#292134}

Powered by Google App Engine
This is Rietveld 408576698