Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Issue 512663002: Cleanup: Remove misc unneeded grit includes. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, benquan, Ilya Sherman, jam, dyu1, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, kalyank, browser-components-watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Dane Wallinga, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove misc unneeded grit includes. Committed: https://crrev.com/ba81a156269139419d7cc6af18f672a17a423e70 Cr-Commit-Position: refs/heads/master@{#292448}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -28 lines) Patch
M ash/frame/default_header_painter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/shelf_delegate_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/audio/tray_audio.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/chromeos/audio/audio_detailed_view.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/system/chromeos/audio/tray_audio_delegate_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/tray_notification_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/user/accounts_detailed_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/user/accounts_detailed_view.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/test_shelf_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/automation_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_profile_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/content/distiller_page_web_contents_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
thestig@chromium.org changed reviewers: + caitkp@chromium.org, jamescook@chromium.org
6 years, 3 months ago (2014-08-27 22:08:56 UTC) #1
Lei Zhang
jamescook: ash/ and chrome/ - there is a bit of lint cleanup as well. caitkp: ...
6 years, 3 months ago (2014-08-27 22:08:56 UTC) #2
James Cook
LGTM. Thanks for taking on these kinds of tasks.
6 years, 3 months ago (2014-08-27 23:43:13 UTC) #3
Lei Zhang
thestig@chromium.org changed reviewers: + erikwright@chromium.org
6 years, 3 months ago (2014-08-28 17:50:40 UTC) #4
Lei Zhang
+erikwright for components/
6 years, 3 months ago (2014-08-28 17:50:40 UTC) #5
tfarina
I'd pick isherman for autofill and cjhopman for dom_distiller. If a single reviewer for components/ ...
6 years, 3 months ago (2014-08-28 17:56:14 UTC) #6
erikwright (departed)
components/ LGTM.
6 years, 3 months ago (2014-08-28 18:00:02 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-28 18:04:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/512663002/20001
6 years, 3 months ago (2014-08-28 18:05:36 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 19:12:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e0ca95ef0b2568203de43a847f6b36718b8a3536
6 years, 3 months ago (2014-08-28 20:26:18 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:44 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba81a156269139419d7cc6af18f672a17a423e70
Cr-Commit-Position: refs/heads/master@{#292448}

Powered by Google App Engine
This is Rietveld 408576698