Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 512623002: Oilpan: fix build after r180932. (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r180932. TBR=oilpan-reviews BUG=396585 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/core/css/TreeBoundaryCrossingRules.h View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/css/TreeBoundaryCrossingRules.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sof
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
6 years, 3 months ago (2014-08-27 06:27:46 UTC) #1
sof
Please take a look.
6 years, 3 months ago (2014-08-27 06:27:46 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 3 months ago (2014-08-27 06:35:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/512623002/1
6 years, 3 months ago (2014-08-27 06:36:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 180935
6 years, 3 months ago (2014-08-27 06:36:52 UTC) #5
Mads Ager (chromium)
ager@chromium.org changed reviewers: + ager@chromium.org
6 years, 3 months ago (2014-08-27 06:37:09 UTC) #6
Mads Ager (chromium)
lgtm
6 years, 3 months ago (2014-08-27 06:37:09 UTC) #7
kochi
kochi@chromium.org changed reviewers: + kochi@chromium.org
6 years, 3 months ago (2014-08-27 06:43:23 UTC) #8
kochi
Thanks!!
6 years, 3 months ago (2014-08-27 06:43:23 UTC) #9
haraken
LGTM
6 years, 3 months ago (2014-08-27 07:39:46 UTC) #10
kochi
I'll make sure someone working on Oilpan involved when getting reviews including adding a new ...
6 years, 3 months ago (2014-08-27 07:56:40 UTC) #11
sof
6 years, 3 months ago (2014-08-27 08:04:23 UTC) #12
Message was sent while issue was closed.
On 2014/08/27 07:56:40, Takayoshi Kochi wrote:
> I'll make sure someone working on Oilpan involved when
> getting reviews including adding a new class
> or sensibly modifying the Oilpan-enabled class
> from next time.
> 

If you're unsure of Oilpan handling in any way, just Cc: oilpan-reviews and
we'll be more than happy to have a look.

> Sorry for the mess.

Build trouble is for Oilpan-involved people to address, so don't be :) But early
warning (by way of reviews) of possible trouble is appreciated.

Powered by Google App Engine
This is Rietveld 408576698