Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 512603003: Adds conversion rule for WebAXRoleFigure (Closed)

Created:
6 years, 3 months ago by je_julie(Not used)
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds conversion rule for WebAXRoleFigure The Related CL: https://codereview.chromium.org/515843002/ BUG=282040 Committed: https://crrev.com/a2465eaa9471d741000f957583cf81dd2c31ecd8 Cr-Commit-Position: refs/heads/master@{#293081}

Patch Set 1 #

Patch Set 2 : added role mapping to platform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
je_julie(Not used)
je_julie.kim@samsung.com changed reviewers: + dmazzoni@chromium.org
6 years, 3 months ago (2014-08-28 08:25:09 UTC) #1
je_julie(Not used)
dmazzoni, PTAL
6 years, 3 months ago (2014-08-29 10:33:10 UTC) #2
dmazzoni
Please add mappings to browser_accessibility_win.cc and ax_platform_node_mac.mm based on: http://www.w3.org/TR/html-aapi/
6 years, 3 months ago (2014-08-29 11:09:19 UTC) #3
je_julie(Not used)
On 2014/08/29 11:09:19, dmazzoni wrote: > Please add mappings to browser_accessibility_win.cc and ax_platform_node_mac.mm > based ...
6 years, 3 months ago (2014-08-29 13:48:21 UTC) #4
dmazzoni
lgtm
6 years, 3 months ago (2014-09-01 06:49:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/je_julie.kim@samsung.com/512603003/20001
6 years, 3 months ago (2014-09-02 01:31:25 UTC) #7
je_julie(Not used)
On 2014/09/02 02:00:20, je_julie.kim wrote: > The CQ bit was unchecked by mailto:je_julie.kim@samsung.com I didn't ...
6 years, 3 months ago (2014-09-02 02:02:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/je_julie.kim@samsung.com/512603003/20001
6 years, 3 months ago (2014-09-03 01:39:17 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 02:59:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8307)
6 years, 3 months ago (2014-09-03 03:03:57 UTC) #14
dmazzoni
Here's the error. I didn't realize you were a new contributor. Please sign the CLA ...
6 years, 3 months ago (2014-09-03 05:47:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/je_julie.kim@samsung.com/512603003/20001
6 years, 3 months ago (2014-09-03 05:59:54 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d2bdf70ccd6cf47b638b2a888ee6b7c2a178b00b
6 years, 3 months ago (2014-09-03 06:08:06 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:23:52 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2465eaa9471d741000f957583cf81dd2c31ecd8
Cr-Commit-Position: refs/heads/master@{#293081}

Powered by Google App Engine
This is Rietveld 408576698