Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 512573003: Content verification: Don't fail on non-existence. (Closed)

Created:
6 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, asargent_no_longer_on_chrome
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Content verification: Don't fail on non-existence. This prevents content verification (when active) from disabling an extension when the extension attempts to load a non-existent resource in its own chrome-extension URL space. BUG=404802 Committed: https://crrev.com/88d96e66d39684c2f8c9336042836dc90f4be85b Cr-Commit-Position: refs/heads/master@{#292095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M extensions/browser/content_hash_reader.h View 2 chunks +8 lines, -2 lines 0 comments Download
M extensions/browser/content_hash_reader.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M extensions/browser/content_verify_job.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ken Rockot(use gerrit already)
rockot@chromium.org changed reviewers: + yoz@chromium.org
6 years, 3 months ago (2014-08-27 01:34:36 UTC) #1
Ken Rockot(use gerrit already)
Yoyo could you please take a look? You have been chosen at random. How exciting! ...
6 years, 3 months ago (2014-08-27 01:34:36 UTC) #2
Yoyo Zhou
I will have to randomly LGTM it then!
6 years, 3 months ago (2014-08-27 01:43:26 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 3 months ago (2014-08-27 03:12:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/512573003/1
6 years, 3 months ago (2014-08-27 03:12:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as bec2f2c3a36a6f82a7f3e6cec362c346ec14f9e0
6 years, 3 months ago (2014-08-27 04:26:40 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88d96e66d39684c2f8c9336042836dc90f4be85b
Cr-Commit-Position: refs/heads/master@{#292095}

Powered by Google App Engine
This is Rietveld 408576698