Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 512573002: Revert of Revert "TestWebServer needs to use a free port." (Closed)

Created:
6 years, 3 months ago by hush (inactive)
Modified:
6 years, 3 months ago
Reviewers:
Yaron, awong
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "TestWebServer needs to use a free port." (patchset #1 of https://codereview.chromium.org/514443002/) Reason for revert: I will land the following CL to fix the findbugs warning https://codereview.chromium.org/513583002/ Then I will revert the revert. Original issue's description: > Revert "TestWebServer needs to use a free port." > > Causing Android Build (dbg) findbugs to fail. > > This reverts commit c4a3f88c4434e86057a8c7ae4e109b8be4138d8f. > > BUG=none > TBR=hush > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/b055d91 TBR=ajwong@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/955c8c92ba0f33666d911b015f5c36fc2303dc6f Cr-Commit-Position: refs/heads/master@{#292218}

Patch Set 1 #

Total comments: 1

Patch Set 2 : findbugs fix + previous CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java View 1 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hush (inactive)
Created Revert of Revert "TestWebServer needs to use a free port."
6 years, 3 months ago (2014-08-27 01:21:23 UTC) #1
hush (inactive)
hush@chromium.org changed reviewers: + yfriedman@chromium.org
6 years, 3 months ago (2014-08-27 01:23:02 UTC) #2
Yaron
https://codereview.chromium.org/512573002/diff/1/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java File net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java (right): https://codereview.chromium.org/512573002/diff/1/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java#newcode63 net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:63: public class TestWebServer { Just upload the fix to ...
6 years, 3 months ago (2014-08-27 05:31:05 UTC) #3
hush (inactive)
On 2014/08/27 05:31:05, Yaron wrote: > https://codereview.chromium.org/512573002/diff/1/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java > File > net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java > (right): > > ...
6 years, 3 months ago (2014-08-27 17:09:27 UTC) #4
Yaron
lgtm
6 years, 3 months ago (2014-08-27 18:06:33 UTC) #5
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 3 months ago (2014-08-27 21:03:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/512573002/40001
6 years, 3 months ago (2014-08-27 21:04:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 27777388a37d12dd7cbdd397c07874261c28206b
6 years, 3 months ago (2014-08-27 21:05:32 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/955c8c92ba0f33666d911b015f5c36fc2303dc6f
Cr-Commit-Position: refs/heads/master@{#292218}

Powered by Google App Engine
This is Rietveld 408576698