Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 512563002: Move ColorChooser{,Client} and DateTimeChooser{,Client} from platform to core. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, gavinp+loader_chromium.org, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Move ColorChooser{,Client} and DateTimeChooser{,Client} from platform to core. We're going to add |Element& ownerElement()| to ColorChooserClient and DateTimeChooserClient, and add |AXObject* rootAXObject()| to ColorChooser and DateTimeChooser. Classes in platform/ can't refer to core classes such as Element and AXObject. So we move these classes. BUG=123896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180934

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -445 lines) Patch
M Source/core/core.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/ColorChooser.h View 1 chunk +1 line, -3 lines 0 comments Download
A + Source/core/html/forms/ColorChooser.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/core/html/forms/ColorChooserClient.h View 2 chunks +1 line, -2 lines 0 comments Download
A + Source/core/html/forms/ColorChooserClient.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/forms/ColorInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ColorInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/DateTimeChooser.h View 2 chunks +1 line, -2 lines 0 comments Download
A + Source/core/html/forms/DateTimeChooser.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/DateTimeChooserClient.h View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/core/html/forms/DateTimeChooserClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/shadow/PickerIndicatorElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/Chrome.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/platform/ColorChooser.h View 1 chunk +0 lines, -50 lines 0 comments Download
D Source/platform/ColorChooser.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/platform/ColorChooserClient.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/platform/ColorChooserClient.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/platform/DateTimeChooser.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/platform/DateTimeChooser.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/platform/DateTimeChooserClient.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/platform/DateTimeChooserClient.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
M Source/platform/blink_platform.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/ColorChooserPopupUIController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ColorChooserUIController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ColorChooserUIController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/DateTimeChooserImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ExternalDateTimeChooser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ExternalDateTimeChooser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDateTimeSuggestion.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tkent
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-26 23:37:28 UTC) #1
tkent
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-26 23:38:53 UTC) #2
tkent
Patchset #1 (id:40001) has been deleted
6 years, 3 months ago (2014-08-27 00:08:10 UTC) #3
tkent
tkent@chromium.org changed reviewers: + keishi@chromium.org
6 years, 3 months ago (2014-08-27 01:05:20 UTC) #4
tkent
Please review this.
6 years, 3 months ago (2014-08-27 01:05:20 UTC) #5
keishi
lgtm
6 years, 3 months ago (2014-08-27 04:17:40 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 3 months ago (2014-08-27 04:18:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/512563002/60001
6 years, 3 months ago (2014-08-27 04:18:56 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-08-27 04:23:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (60001) as 180934

Powered by Google App Engine
This is Rietveld 408576698