Issue 512553003: Remove include of ui/events/event.h from device_data_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 512553003: Remove include of ui/events/event.h from device_data_manager (Closed)

Created:
6 years, 3 months ago by sky

Modified:
6 years, 3 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tdresser+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove include of ui/events/event.h from device_data_manager device_data_manager shouldn't include event.h as they are in different targets and we don't want event_base depending upon event. BUG=none TEST=none R=sadrul@chromium.org Committed: https://crrev.com/73e898c31773acec6410b50e349be4ac050daa57 Cr-Commit-Position: refs/heads/master@{#292301}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/events/x/device_data_manager_x11.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/events/x/events_x.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/512553003/1

6 years, 3 months ago (2014-08-28 02:20:14 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 17c4af9dc67df6c37043f4d6616372427cd75de5

6 years, 3 months ago (2014-08-28 02:52:59 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:56:48 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/73e898c31773acec6410b50e349be4ac050daa57
Cr-Commit-Position: refs/heads/master@{#292301}

Expand Messages | Collapse Messages