Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 512553002: ozone: evdev: Use tracking id for TouchEvent finger id (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, rjkroege, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Use tracking id for TouchEvent finger id We're supposed to use a unique id that increments for each distinct touch. That's tracking id, not slot. BUG=none TEST=chrome on pixel with --ash-touch-hud NOTRY=true Committed: https://crrev.com/f1e78836b0c4c44b5a30031761c79d13e4e9e8f7 Cr-Commit-Position: refs/heads/master@{#292306}

Patch Set 1 #

Patch Set 2 : add/fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 1 chunk +9 lines, -10 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 12 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
spang
spang@chromium.org changed reviewers: + alexst@chromium.org, miletus@chromium.org
6 years, 3 months ago (2014-08-26 22:20:56 UTC) #1
spang
6 years, 3 months ago (2014-08-26 22:20:56 UTC) #2
Yufeng Shen (Slow to review)
miletus@chromium.org changed reviewers: + sadrul@chromium.org
6 years, 3 months ago (2014-08-26 23:31:55 UTC) #3
sadrul
Can you add a test in touch_event_converter_evdev_unittest.cc?
6 years, 3 months ago (2014-08-27 01:35:58 UTC) #4
alexst (slow to review)
lgtm
6 years, 3 months ago (2014-08-27 18:56:45 UTC) #5
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-28 03:31:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/512553002/20001
6 years, 3 months ago (2014-08-28 03:33:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b51e00fc35fc4172f51bd711551c7724f2428560
6 years, 3 months ago (2014-08-28 03:34:13 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1e78836b0c4c44b5a30031761c79d13e4e9e8f7
Cr-Commit-Position: refs/heads/master@{#292306}

Powered by Google App Engine
This is Rietveld 408576698