Remove showModalDialog layout tests

Remove showModalDialog layout tests

This removes most of the automatic and manual tests using
showModalDialog.  The remaining tests are window property tests and
tests to make sure you can't call it from an iframe that can get cleaned
up when the function gets removed once and for all.

R=abarth@chromium.org,jamesr@chromium.org
BUG=345831
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181064

[caseq, 2014-08-27 06:12:15]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org, pfeldman@chromium.org

[caseq, 2014-08-27 06:12:15]

I'm not sure it's fair to remove console-long-eval-crash.html -- it doesn't test
showModalDialog per se, just uses it as a means of having a nested message loop
I guess. Perhaps it can be replaced with a sync xhr?

[jamesr, 2014-08-27 08:01:25]

The entire point is we don't support running a nested message loop any more.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[pfeldman, 2014-08-27 08:32:17]

@jamesr: the test was not about nested message loop itself. Iirc it was using
nested loop in order to create a race between fron-end closing and something
else.

I think we could still emulate this behavior using alert() and one of the Page.*
protocol methods that close message dialogs.

[caseq, 2014-08-27 08:40:52]

jamesr, doesn't alert() run a nested message loop after all? How about JS
breakpoints?

[enne (OOO), 2014-08-27 19:51:04]

I can leave the console-long-eval-crash test undeleted and file a bug to rewrite
it, if that's the only objection.

[yurys, 2014-08-28 08:21:11]

On 2014/08/27 08:01:25, jamesr wrote:
> The entire point is we don't support running a nested message loop any more.
> 

Not related to this CL directly but what's the plan for eliminating nested loop
in the JS debugger code?

[enne (OOO), 2014-08-28 18:14:37]

Pinging all y'all-

jamesr/abarth: Could you please review this patch? Again, I am happy to remove
the console-long-eval-crash and file a bug if that is contentious.

This CL is blocking a ToT crash fix in
https://codereview.chromium.org/513433002/ because it makes some of these tests
time out.  I suspect this is because of some weirdness in how layout tests shut
down combined with this nested message loop weirdness, but don't have a full
handle on why this is.

[jamesr, 2014-08-28 18:58:58]

lgtm

if we want to test JS pausing or any other scenarios we should have tests for
those scenarios

[enne (OOO), 2014-08-28 22:08:32]

caseq: showModalDialog is going away and so I'm going to remove
console-long-eval-crash.  If you want to keep testing whatever this test was
trying to test against, please add a new test that does not use showModalDialog.

[enne (OOO), 2014-08-28 22:08:38]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-08-28 22:09:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/512533002/1

[commit-bot: I haz the power, 2014-08-28 23:22:50]

Committed patchset #1 (id:1) as 181064