Safebrowsing: send enhanced download protection pings on OSX.

Safebrowsing: allow sending enhanced download protection pings on OSX.

Sending is controlled by a finch experiment.

The verdict from the server is ignored for now.

BUG=413967
Committed: https://crrev.com/d117e91057252e860a551fbe62b7e4446c872828
Cr-Commit-Position: refs/heads/master@{#295191}

[mattm, 2014-09-13 00:14:22]

Patchset #2 (id:20001) has been deleted

[mattm, 2014-09-13 00:38:59]

mattm@chromium.org changed reviewers:
+ noelutz@chromium.org

[mattm, 2014-09-13 00:39:00]

Depends on https://codereview.chromium.org/565053002/

noelutz: review
asanka, moheeb: fyi

[noé, 2014-09-15 16:10:03]

lgtm

https://codereview.chromium.org/512513002/diff/80001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/download_protection_service.cc (right):

https://codereview.chromium.org/512513002/diff/80001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/download_protection_service.cc:944: // TODO(mattm):
remove this (see crbug.com/X).
s/X/413968 ?

[mattm, 2014-09-16 20:04:20]

Also fixed missing the check of the finch trial before sending the ping.

https://codereview.chromium.org/512513002/diff/80001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/download_protection_service.cc (right):

https://codereview.chromium.org/512513002/diff/80001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/download_protection_service.cc:944: // TODO(mattm):
remove this (see crbug.com/X).
On 2014/09/15 16:10:03, noé wrote:
> s/X/413968 ?

Done (used the finch experiment bug number)

[mattm, 2014-09-16 22:56:10]

On 2014/09/16 20:04:20, mattm wrote:
> Also fixed missing the check of the finch trial before sending the ping.
> 
>
https://codereview.chromium.org/512513002/diff/80001/chrome/browser/safe_brow...
> File chrome/browser/safe_browsing/download_protection_service.cc (right):
> 
>
https://codereview.chromium.org/512513002/diff/80001/chrome/browser/safe_brow...
> chrome/browser/safe_browsing/download_protection_service.cc:944: //
TODO(mattm):
> remove this (see crbug.com/X).
> On 2014/09/15 16:10:03, noé wrote:
> > s/X/413968 ?
> 
> Done (used the finch experiment bug number)

Updated to always return false in IsSupportedDownload. This removes the
dependency on https://codereview.chromium.org/533883002/, but means if a
dangerous download warning is hit, a ping won't be sent unless the user clicks
"keep". We can re-add that later.

[noé, 2014-09-16 22:59:36]

lgtm

[mattm, 2014-09-16 23:00:01]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-09-16 23:01:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/512513002/120001

[commit-bot: I haz the power, 2014-09-17 00:45:52]

Committed patchset #6 (id:120001) as 64dbb8e7984c9020b902473755b30c568e35d747

[commit-bot: I haz the power, 2014-09-17 00:46:22]

Patchset 6 (id:??) landed as
https://crrev.com/d117e91057252e860a551fbe62b7e4446c872828
Cr-Commit-Position: refs/heads/master@{#295191}