Issue 512493003: Remove an unncessary check on signature length being 0.

Issue 512493003: Remove an unncessary check on signature length being 0. (Closed)

Created:
6 years, 3 months ago by eroman

Modified:
6 years, 3 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove an unncessary check on signature length being 0. BUG=407863 Committed: https://crrev.com/3865166e53f5e570283e92773203d87cd26ddc31 Cr-Commit-Position: refs/heads/master@{#292242}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	content/child/webcrypto/algorithm_dispatch.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 8 (0 generated)

eroman

eroman@chromium.org changed reviewers: + rsleevi@chromium.org

6 years, 3 months ago (2014-08-26 23:05:17 UTC) #1

eroman

Note that there are already tests for both HMAC and RSA-SSA which pass an empty ...

6 years, 3 months ago (2014-08-26 23:05:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/512493003/1

6 years, 3 months ago (2014-08-27 20:53:15 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium.mac ...

6 years, 3 months ago (2014-08-27 22:04:47 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as 8aff3dbc8c2d3da88a6ec665722d4924d9d2c8f8

6 years, 3 months ago (2014-08-27 22:11:42 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:54:43 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3865166e53f5e570283e92773203d87cd26ddc31
Cr-Commit-Position: refs/heads/master@{#292242}