Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 512493002: Be verbose about what's happening in 'git cl land' when pusing to pending ref. (Closed)

Created:
5 years ago by Vadim Sh.
Modified:
5 years ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Be verbose about what's happening in 'git cl land' when pusing to pending ref. Also reduce number of attempts and give up right away on ACL errors. R=iannucci@chromium.org BUG=407369, 407470 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291656

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M git_cl.py View 1 chunk +32 lines, -9 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Vadim Sh.
ptal verified on sandbox https://codereview.chromium.org/512493002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/512493002/diff/1/git_cl.py#newcode2131 git_cl.py:2131: print out.strip() that was the ...
5 years ago (2014-08-26 21:12:05 UTC) #1
iannucci
lgtm
5 years ago (2014-08-26 21:53:35 UTC) #2
Vadim Sh.
The CQ bit was checked by vadimsh@chromium.org
5 years ago (2014-08-26 21:55:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/512493002/1
5 years ago (2014-08-26 21:56:08 UTC) #4
commit-bot: I haz the power
5 years ago (2014-08-26 21:57:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 291656

Powered by Google App Engine
This is Rietveld 408576698