chrome/common/extensions/docs/server2/chained_compiled_file_system.py - Issue 512453002: Docserver: Add more skip_not_found support and cache "not found"s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/chained_compiled_file_system.py

Issue 512453002: Docserver: Add more skip_not_found support and cache "not found"s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bumpin yaml Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/caching_file_system_test.py ('k') | chrome/common/extensions/docs/server2/compiled_file_system.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/chained_compiled_file_system.py

diff --git a/chrome/common/extensions/docs/server2/chained_compiled_file_system.py b/chrome/common/extensions/docs/server2/chained_compiled_file_system.py

index 74e2a59a3c73286b92c1580d0ac34e9c6512c78f..1b5640d354424636f7cef3b147b6783a0e086d60 100644

--- a/chrome/common/extensions/docs/server2/chained_compiled_file_system.py

+++ b/chrome/common/extensions/docs/server2/chained_compiled_file_system.py

@@ -46,11 +46,11 @@ class ChainedCompiledFileSystem(object):

self._compiled_fs_chain = compiled_fs_chain

self._identity = identity

- def GetFromFile(self, path):

+ def GetFromFile(self, path, skip_not_found=False):

return self._GetImpl(

path,

- lambda compiled_fs: compiled_fs.GetFromFile(path),

- lambda compiled_fs: compiled_fs.GetFileVersion(path))

+ lambda cfs: cfs.GetFromFile(path, skip_not_found=skip_not_found),

+ lambda cfs: cfs.GetFileVersion(path))

def GetFromFileListing(self, path):

path = ToDirectory(path)