Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 512413002: Move Preload enum to BufferedDataSource. (Closed)

Created:
6 years, 3 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move Preload enum to BufferedDataSource. Moving the Preload out of the content namespace and into BufferedDataSource since that class is the primary reason this enum exists. BUG=408338 Committed: https://crrev.com/a5081a4c324d1f817523f58be4a99d57cb279d74 Cr-Commit-Position: refs/heads/master@{#292503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -45 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/buffered_data_source.h View 2 chunks +12 lines, -1 line 0 comments Download
M content/renderer/media/buffered_data_source_unittest.cc View 10 chunks +14 lines, -14 lines 0 comments Download
D content/renderer/media/preload.h View 1 chunk +0 lines, -25 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
acolwell GONE FROM CHROMIUM
acolwell@chromium.org changed reviewers: + scherkus@chromium.org
6 years, 3 months ago (2014-08-28 21:48:36 UTC) #1
acolwell GONE FROM CHROMIUM
6 years, 3 months ago (2014-08-28 21:48:36 UTC) #2
scherkus (not reviewing)
lgtm
6 years, 3 months ago (2014-08-28 21:51:37 UTC) #3
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 3 months ago (2014-08-28 21:53:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/512413002/1
6 years, 3 months ago (2014-08-28 21:53:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as e88b68784938607246b48e1b8f4381b9df5e8ae4
6 years, 3 months ago (2014-08-28 23:42:59 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5081a4c324d1f817523f58be4a99d57cb279d74
Cr-Commit-Position: refs/heads/master@{#292503}

Powered by Google App Engine
This is Rietveld 408576698