Issue 512323003: Allow web url https://www.google.com/chrome/devices/goodies.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 512323003: Allow web url https://www.google.com/chrome/devices/goodies.html (Closed)

Created:
6 years, 3 months ago by andycai1

Modified:
6 years, 3 months ago

Reviewers:
gauravsh

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, stephenlin

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/chromeos/echo/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

andycai1

andycai@chromium.org changed reviewers: + gauravsh@chromium.org

6 years, 3 months ago (2014-08-28 19:18:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andycai@chromium.org/512323003/1

6 years, 3 months ago (2014-09-03 00:27:34 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as ae477ff13232fbb481f5dbd82d1eff4c9adc6865

6 years, 3 months ago (2014-09-03 04:47:58 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:23:25 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/243889530f1f6b717f7b65b3fe3ad84e1745a28b
Cr-Commit-Position: refs/heads/master@{#293067}