Issue 512243002: Revert of add gamma/sRGB to SkImageInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 512243002: Revert of add gamma/sRGB to SkImageInfo (Closed)

Created:
6 years, 3 months ago by reed1

Modified:
6 years, 3 months ago

Reviewers:
bungeman-skia, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of add gamma/sRGB to SkImageInfo (patchset #4 of https://codereview.chromium.org/514753002/) Reason for revert: breaks linker on chrome -- may need SK_API, but not sure. Original issue's description: > add gamma/sRGB to SkImageInfo > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/615c369777258231054840a88cdb74c68c382485 TBR=bungeman@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/dc53701216c0e9f98eacf6c0cda769ebbd200b59

Patch Set 1 #

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -240 lines)			Patch
M	gyp/tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkImageInfo.h	View	4 chunks	+24 lines, -64 lines	0 comments	Download
M	src/core/SkImageInfo.cpp	View	2 chunks	+21 lines, -111 lines	0 comments	Download
D	tests/ImageInfoTest.cpp	View	1 chunk	+0 lines, -64 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/512243002/1

6 years, 3 months ago (2014-08-28 13:53:15 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as dc53701216c0e9f98eacf6c0cda769ebbd200b59

6 years, 3 months ago (2014-08-28 13:53:24 UTC) #3

reed1

6 years, 3 months ago (2014-08-28 18:56:31 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/511363002/ by reed@google.com.

The reason for reverting is: this revert was premature -- the chrome canary I
looked at is old, and newer ones were green. So trying again....

Expand Messages | Collapse Messages