Documented how to add bookmark folders with the ManagedBookmarks policy.

Documented how to add bookmark folders with the ManagedBookmarks policy.

BUG=None

Committed: https://crrev.com/3074bba6ac72e209f68906839317508f4cbbc53a
Cr-Commit-Position: refs/heads/master@{#292377}

[Joao da Silva, 2014-08-28 13:16:47]

joaodasilva@chromium.org changed reviewers:
+ bartfab@chromium.org

[Joao da Silva, 2014-08-28 13:16:47]

PTAL, thanks!

[bartfab (slow), 2014-08-28 13:21:18]

lgtm

https://codereview.chromium.org/512223002/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/512223002/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:6421: A bookmark can also be
configured as a folder. In that case, define the folder "name" but don't define
an "url"; instead, define the folder contents as another list of bookmarks under
the "children" key.
Nit: Is it possible to specify in JSON schema somehow that there can only be
either |url| or |children|?

[Joao da Silva, 2014-08-28 13:38:10]

https://codereview.chromium.org/512223002/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/512223002/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:6421: A bookmark can also be
configured as a folder. In that case, define the folder "name" but don't define
an "url"; instead, define the folder contents as another list of bookmarks under
the "children" key.
On 2014/08/28 13:21:17, bartfab wrote:
> Nit: Is it possible to specify in JSON schema somehow that there can only be
> either |url| or |children|?

It is but it's complicated :-)

Basically, the "type" field can map to a specific type (that's what we're using
all over the place) but it can also map to a list of types. In that case, the
value must match one of those types. This simple example would allow a string or
a boolean:

  "type": [ "string", "boolean" ]

Interestingly, instead of naming a type you can just inline another schema.

So the "type: object" line above could be broken into "type: [ { schema_for_urls
}, { schema_for_folders } ]"

Unfortunately the schema validator doesn't support this yet :-) It's nice that
JSON schema can express union types like this, but I'm not sure we will
implement it without a good reason for it.

[Joao da Silva, 2014-08-28 13:38:16]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-08-28 13:39:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/512223002/1

[commit-bot: I haz the power, 2014-08-28 14:12:16]

Committed patchset #1 (id:1) as 00a292e523495e4dbc502e34f52feb921cf60800

[commit-bot: I haz the power, 2014-09-10 02:59:23]

Patchset 1 (id:??) landed as
https://crrev.com/3074bba6ac72e209f68906839317508f4cbbc53a
Cr-Commit-Position: refs/heads/master@{#292377}