Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: LayoutTests/http/tests/serviceworker/unregister.html

Issue 512163002: ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (3/4) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Correct patch Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/serviceworker/unregister.html
diff --git a/LayoutTests/http/tests/serviceworker/unregister.html b/LayoutTests/http/tests/serviceworker/unregister.html
index ae3bcae6ea185f0c1e36c7225a8d0a9e8e5bec45..d236119424866e002796a080de4bdc761456492b 100644
--- a/LayoutTests/http/tests/serviceworker/unregister.html
+++ b/LayoutTests/http/tests/serviceworker/unregister.html
@@ -28,8 +28,10 @@ async_test(function(t) {
return registration.unregister();
})
.then(function(value) {
- assert_equals(value, undefined,
- 'unregistering twice should resolve with no value');
+ // FIXME: This value must be false in spec, but this is not supported now.
nhiroki 2014/09/01 08:43:03 Can you wrap this at 80 columns?
+ // See: https://crbug.com/390894#c16
+ assert_equals(value, true,
+ 'unregistering twice should resolve with false, but now this will be true');
nhiroki 2014/09/01 08:43:03 ditto. (IMHO, just "unregistering twice should re
t.done();
})
.catch(unreached_rejection(t));
@@ -43,8 +45,8 @@ async_test(function(t) {
return registration.unregister();
})
.then(function(value) {
- assert_equals(value, undefined,
- 'unregistration should resolve with no value');
+ assert_equals(value, true,
+ 'unregistration should resolve with true');
t.done();
})
.catch(unreached_rejection(t));
@@ -65,7 +67,7 @@ async_test(function(t) {
return navigator.serviceWorker.unregister();
})
.then(function(value) {
- assert_equals(value, undefined,
+ assert_equals(value, true,
'unregister with default scope should succeed');
return state_promise;
})
« no previous file with comments | « no previous file | Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698