Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: public/platform/WebServiceWorkerProvider.h

Issue 512163002: ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (3/4) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerRegistration.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebServiceWorkerProvider.h
diff --git a/public/platform/WebServiceWorkerProvider.h b/public/platform/WebServiceWorkerProvider.h
index eb2adf7618e3e16bc011258bb3ccec1ef983f7db..9e138e05943234e50d469e66a134bc18e2e90cef 100644
--- a/public/platform/WebServiceWorkerProvider.h
+++ b/public/platform/WebServiceWorkerProvider.h
@@ -42,10 +42,6 @@ class WebServiceWorkerProviderClient;
class WebServiceWorkerRegistration;
struct WebServiceWorkerError;
-// FIXME: Remove this macro after the chromium side patch is applied
-// See: https://crbug.com/390894
-#define DISABLE_SERVICEWORKER_UNREGISTER_RESOLVE_TO_BOOLEAN
-
// Created on the main thread, and may be passed to another script context
// thread (e.g. worker thread) later. All methods of this class must be called
// on the single script context thread.
@@ -58,11 +54,7 @@ public:
// The WebServiceWorkerRegistration and WebServiceWorkerError ownership are
// passed to the WebServiceWorkerRegistrationCallbacks implementation.
typedef WebCallbacks<WebServiceWorkerRegistration, WebServiceWorkerError> WebServiceWorkerRegistrationCallbacks;
-#ifdef DISABLE_SERVICEWORKER_UNREGISTER_RESOLVE_TO_BOOLEAN
- typedef WebServiceWorkerRegistrationCallbacks WebServiceWorkerUnregistrationCallbacks;
-#else
typedef WebCallbacks<bool, WebServiceWorkerError> WebServiceWorkerUnregistrationCallbacks;
-#endif
virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptUrl, WebServiceWorkerRegistrationCallbacks*) { }
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerRegistration.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698