Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 512153002: Manual fixups for scoped_refptr operator T* removal in ipc/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Manual fixups for scoped_refptr operator T* removal in ipc/ BUG=110610 Committed: https://crrev.com/fd03370152e9020155b53ac3d381303b78b20486 Cr-Commit-Position: refs/heads/master@{#292404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M ipc/ipc_channel_proxy.h View 2 chunks +7 lines, -5 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M ipc/ipc_sync_channel.h View 4 chunks +11 lines, -9 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + tsepez@chromium.org
6 years, 3 months ago (2014-08-28 09:35:45 UTC) #1
dcheng
These are manual fixups for the cases that the automated tool decided to skip. I've ...
6 years, 3 months ago (2014-08-28 09:35:45 UTC) #2
Tom Sepez
lgtm
6 years, 3 months ago (2014-08-28 16:26:06 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-28 16:29:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/512153002/1
6 years, 3 months ago (2014-08-28 16:30:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 27226f575fba0a43c191d4f70cb1fef377663df3
6 years, 3 months ago (2014-08-28 16:59:36 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd03370152e9020155b53ac3d381303b78b20486
Cr-Commit-Position: refs/heads/master@{#292404}

Powered by Google App Engine
This is Rietveld 408576698