Deprecate old Safe Browsing reporting opt-ins

Deprecate old Safe Browsing reporting opt-ins

The old prefs are no longer needed; M39 should be a sufficiently long
transition time period.

BUG=384668
R=mattm@chromium.org

Committed: https://crrev.com/a55ae06b3a59bc1b9b97ef432adff20073b884a5
Cr-Commit-Position: refs/heads/master@{#292974}

[felt, 2014-08-28 02:28:43]

matt: PTAL

[mattm, 2014-08-28 20:57:01]

https://codereview.chromium.org/512083002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):

https://codereview.chromium.org/512083002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:917:
prefs::kSafeBrowsingExtendedReportingEnabled)) {
This HasPrefPath shouldn't be needed anymore

[felt, 2014-08-28 21:43:31]

https://codereview.chromium.org/512083002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):

https://codereview.chromium.org/512083002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:917:
prefs::kSafeBrowsingExtendedReportingEnabled)) {
On 2014/08/28 20:57:01, mattm wrote:
> This HasPrefPath shouldn't be needed anymore

you're right. re-tested with both clean and dirty state, it appears to work now.

[mattm, 2014-08-28 21:45:35]

lgtm

[felt, 2014-08-28 21:50:48]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-08-28 21:51:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/felt@chromium.org/512083002/20001

[commit-bot: I haz the power, 2014-08-28 23:35:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47818)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-28 23:40:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 23:40:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[felt, 2014-08-29 00:25:52]

felt@chromium.org changed reviewers:
+ erg@chromium.org

[felt, 2014-08-29 00:25:52]

erg@, can i please get a review of a small change to
chrome/browser/profiles/profile.cc?

[felt, 2014-09-02 15:19:07]

On 2014/08/29 00:25:52, felt wrote:
> erg@, can i please get a review of a small change to
> chrome/browser/profiles/profile.cc?

ping erg@

[Elliot Glaysher, 2014-09-02 18:22:57]

lgtm

[felt, 2014-09-02 18:32:55]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-09-02 18:35:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/felt@chromium.org/512083002/40001

[commit-bot: I haz the power, 2014-09-02 19:29:20]

Committed patchset #3 (id:40001) as e98c8fa609060248f704cac6575ac5a7a0c274bc

[commit-bot: I haz the power, 2014-09-10 03:19:57]

Patchset 3 (id:??) landed as
https://crrev.com/a55ae06b3a59bc1b9b97ef432adff20073b884a5
Cr-Commit-Position: refs/heads/master@{#292974}