Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 512073002: Cleanup of SafeBrowsingBlockingPageBrowserTest tests (Closed)

Created:
6 years, 3 months ago by felt
Modified:
6 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup of SafeBrowsingBlockingPageBrowserTest tests * Make MalwareIframeReportDetails work with V3 and reenable it * Make ReportingDisabled work with V3 and reenable it * Remove TODO from PhishingProceed, since it's been enabled for a while * Remove TODO from PhishingLearnMore, since it's been enabled for a while * Remove logging statements scattered around BUG=273302, 247763 R=mattm@chromium.org Committed: https://crrev.com/4ac70dcc3712fe5e19ba499fb81b3db09f30dae6 Cr-Commit-Position: refs/heads/master@{#292351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -68 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 14 chunks +13 lines, -68 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
felt
Hi Matt, PTAL.
6 years, 3 months ago (2014-08-28 01:34:47 UTC) #1
mattm
lgtm
6 years, 3 months ago (2014-08-28 01:43:02 UTC) #2
felt
The CQ bit was checked by felt@chromium.org
6 years, 3 months ago (2014-08-28 04:14:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/512073002/1
6 years, 3 months ago (2014-08-28 04:15:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as eabc7530c2462327567ba5290a660f59a214dc38
6 years, 3 months ago (2014-08-28 09:00:41 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ac70dcc3712fe5e19ba499fb81b3db09f30dae6
Cr-Commit-Position: refs/heads/master@{#292351}

Powered by Google App Engine
This is Rietveld 408576698