Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 512063003: Manual fixups for scoped_refptr conversion operator cleanup in mojo/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Manual fixups for scoped_refptr conversion operator cleanup in mojo/ BUG=110610 Committed: https://crrev.com/43890436b2626f803ddbdacc70f29929fbd89ae2 Cr-Commit-Position: refs/heads/master@{#292403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M mojo/shell/task_runners.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/shell/task_runners.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/spy/spy.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-28 09:19:20 UTC) #1
dcheng
Some manual fixups. Since these callsites were passing a refcounted object as a raw pointer ...
6 years, 3 months ago (2014-08-28 09:19:20 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-08-28 16:24:39 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-28 16:29:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/512063003/1
6 years, 3 months ago (2014-08-28 16:30:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8174afd9608b3eae84cf16df012cb1c229204717
6 years, 3 months ago (2014-08-28 16:57:36 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/43890436b2626f803ddbdacc70f29929fbd89ae2
Cr-Commit-Position: refs/heads/master@{#292403}

Powered by Google App Engine
This is Rietveld 408576698