Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 512033002: Remove the lies WebMediaPlayerImpl is telling V8. (Closed)

Created:
6 years, 3 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the lies WebMediaPlayerImpl is telling V8. Removing hacky code that sends made up data to V8 to trick it into running GC more often. This was added a long time ago and it is unlikely it is actually helping things anymore. Removing this code also eliminates WebMediaPlayerImpl's dependency on V8 which helps with moving this code to media/blink. BUG=408338 Committed: https://crrev.com/076f537968dbf6d69853501f91e2193a1ebafd6d Cr-Commit-Position: refs/heads/master@{#292303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M content/renderer/media/webmediaplayer_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 6 chunks +0 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
acolwell GONE FROM CHROMIUM
acolwell@chromium.org changed reviewers: + scherkus@chromium.org
6 years, 3 months ago (2014-08-28 00:13:26 UTC) #1
acolwell GONE FROM CHROMIUM
6 years, 3 months ago (2014-08-28 00:13:26 UTC) #2
scherkus (not reviewing)
lgtm x10000000000
6 years, 3 months ago (2014-08-28 00:24:09 UTC) #3
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 3 months ago (2014-08-28 00:31:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/512033002/1
6 years, 3 months ago (2014-08-28 00:32:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:29:59 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:30:00 UTC) #7
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 3 months ago (2014-08-28 03:15:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/512033002/1
6 years, 3 months ago (2014-08-28 03:17:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as c722823adf57e419baf0e9fe6a55615cca558989
6 years, 3 months ago (2014-08-28 03:18:30 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/076f537968dbf6d69853501f91e2193a1ebafd6d
Cr-Commit-Position: refs/heads/master@{#292303}

Powered by Google App Engine
This is Rietveld 408576698