Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: content/child/webcrypto/nss/hmac_nss.cc

Issue 512023002: Refactor the interface for generating keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/webcrypto/nss/hmac_nss.cc
diff --git a/content/child/webcrypto/nss/hmac_nss.cc b/content/child/webcrypto/nss/hmac_nss.cc
index 40dadbe8a399e6dcbdbc4d5ec20dcd7b68e08aad..3a109f7091771555aedeb2fe46ffc11d7ae6c4e2 100644
--- a/content/child/webcrypto/nss/hmac_nss.cc
+++ b/content/child/webcrypto/nss/hmac_nss.cc
@@ -55,10 +55,15 @@ class HmacImplementation : public AlgorithmImplementation {
public:
HmacImplementation() {}
- virtual Status GenerateSecretKey(const blink::WebCryptoAlgorithm& algorithm,
- bool extractable,
- blink::WebCryptoKeyUsageMask usage_mask,
- blink::WebCryptoKey* key) const OVERRIDE {
+ virtual Status GenerateKey(const blink::WebCryptoAlgorithm& algorithm,
+ bool extractable,
+ blink::WebCryptoKeyUsageMask usage_mask,
+ blink::WebCryptoKey*,
+ blink::WebCryptoKey* key) const OVERRIDE {
+ Status status = CheckKeyCreationUsages(kAllKeyUsages, usage_mask);
+ if (status.IsError())
+ return status;
+
const blink::WebCryptoHmacKeyGenParams* params =
algorithm.hmacKeyGenParams();
@@ -68,7 +73,7 @@ class HmacImplementation : public AlgorithmImplementation {
return Status::ErrorUnsupported();
unsigned int keylen_bits = 0;
- Status status = GetHmacKeyGenLengthInBits(params, &keylen_bits);
+ status = GetHmacKeyGenLengthInBits(params, &keylen_bits);
if (status.IsError())
return status;
@@ -93,11 +98,6 @@ class HmacImplementation : public AlgorithmImplementation {
}
}
- virtual Status VerifyKeyUsagesBeforeGenerateKey(
- blink::WebCryptoKeyUsageMask usage_mask) const OVERRIDE {
- return CheckKeyCreationUsages(kAllKeyUsages, usage_mask);
- }
-
virtual Status ImportKeyRaw(const CryptoData& key_data,
const blink::WebCryptoAlgorithm& algorithm,
bool extractable,

Powered by Google App Engine
This is Rietveld 408576698