Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: content/child/webcrypto/openssl/hmac_openssl.cc

Issue 512023002: Refactor the interface for generating keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use a new return type "GenerateKeyPairResult" to encapsulate secretkey vs keypair Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/webcrypto/openssl/hmac_openssl.cc
diff --git a/content/child/webcrypto/openssl/hmac_openssl.cc b/content/child/webcrypto/openssl/hmac_openssl.cc
index c6f6536275d547f4a977eace6b351497812190ae..2989458cbad3b086402e7320d531791c72cc18af 100644
--- a/content/child/webcrypto/openssl/hmac_openssl.cc
+++ b/content/child/webcrypto/openssl/hmac_openssl.cc
@@ -70,15 +70,19 @@ class HmacImplementation : public AlgorithmImplementation {
public:
HmacImplementation() {}
- virtual Status GenerateSecretKey(const blink::WebCryptoAlgorithm& algorithm,
- bool extractable,
- blink::WebCryptoKeyUsageMask usage_mask,
- blink::WebCryptoKey* key) const OVERRIDE {
+ virtual Status GenerateKey(const blink::WebCryptoAlgorithm& algorithm,
+ bool extractable,
+ blink::WebCryptoKeyUsageMask usage_mask,
+ GenerateKeyResult* result) const OVERRIDE {
+ Status status = CheckKeyCreationUsages(kAllKeyUsages, usage_mask);
+ if (status.IsError())
+ return status;
+
const blink::WebCryptoHmacKeyGenParams* params =
algorithm.hmacKeyGenParams();
unsigned int keylen_bits = 0;
- Status status = GetHmacKeyGenLengthInBits(params, &keylen_bits);
+ status = GetHmacKeyGenLengthInBits(params, &keylen_bits);
if (status.IsError())
return status;
@@ -87,7 +91,7 @@ class HmacImplementation : public AlgorithmImplementation {
extractable,
usage_mask,
keylen_bits / 8,
- key);
+ result);
}
virtual Status VerifyKeyUsagesBeforeImportKey(
@@ -102,11 +106,6 @@ class HmacImplementation : public AlgorithmImplementation {
}
}
- virtual Status VerifyKeyUsagesBeforeGenerateKey(
- blink::WebCryptoKeyUsageMask usage_mask) const OVERRIDE {
- return CheckKeyCreationUsages(kAllKeyUsages, usage_mask);
- }
-
virtual Status ImportKeyRaw(const CryptoData& key_data,
const blink::WebCryptoAlgorithm& algorithm,
bool extractable,

Powered by Google App Engine
This is Rietveld 408576698