content/child/webcrypto/nss/aes_key_nss.h - Issue 512023002: Refactor the interface for generating keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/nss/aes_key_nss.h

Issue 512023002: Refactor the interface for generating keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use a new return type "GenerateKeyPairResult" to encapsulate secretkey vs keypair Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/webcrypto/nss/aes_key_nss.h

diff --git a/content/child/webcrypto/nss/aes_key_nss.h b/content/child/webcrypto/nss/aes_key_nss.h

index e1e2ed3f064b15a3a1ed749507481ae54227c082..0cd66cf280b757b33801d49017178df58d1a69a2 100644

--- a/content/child/webcrypto/nss/aes_key_nss.h

+++ b/content/child/webcrypto/nss/aes_key_nss.h

@@ -36,13 +36,10 @@ class AesAlgorithm : public AlgorithmImplementation {

AesAlgorithm(CK_MECHANISM_TYPE import_mechanism,

const std::string& jwk_suffix);

- virtual Status VerifyKeyUsagesBeforeGenerateKey(

- blink::WebCryptoKeyUsageMask usage_mask) const OVERRIDE;

- virtual Status GenerateSecretKey(const blink::WebCryptoAlgorithm& algorithm,

- bool extractable,

- blink::WebCryptoKeyUsageMask usage_mask,

- blink::WebCryptoKey* key) const OVERRIDE;

+ virtual Status GenerateKey(const blink::WebCryptoAlgorithm& algorithm,

+ bool extractable,

+ blink::WebCryptoKeyUsageMask usage_mask,

+ GenerateKeyResult* result) const OVERRIDE;

virtual Status VerifyKeyUsagesBeforeImportKey(

blink::WebCryptoKeyFormat format,